feat: add free trial pricing table to emails when appropriate #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now offering free trials to users who come referred by other users, so we need to be able to display an alternate pricing table to those users. This PR adds a check to the "email validated" screen that determines whether to offer users a free trial. It queries the referral service and renders the "free trial" pricing table if the user was referred. This PR also removes some log lines that I accidentally introduced in a recent PR.
travis
requested review from
alanshaw,
fforbeck,
hannahhoward,
volmedo and
BravoNatalie
View stack outputs
|
Peeja
approved these changes
Dec 11, 2024
Comment on lines
239
to
243
| if (isReferred) { | ||
| stripePricingTableId = context.stripeFreeTrialPricingTableId | ||
| } else { | ||
| stripePricingTableId = context.stripePricingTableId | ||
| } |
There was a problem hiding this comment.
suggestion: …I'm not totally sure what generates these errors for us, but whatever it is, I agree with it. 😄 Let's prefer the ternary to mutating a variable.
| trial - pick a plan below and complete the checkout flow to get started! | ||
| </p> | ||
| <p> | ||
| Please note that after your free trial ends, you will be charged 10 USD per month for Lite or 100 USD per month for Business tier. |
There was a problem hiding this comment.
question: Is it safe to write these values here literally? They won't update if the pricing changes.
also add a couple useful env vars
tests failing in PR
also bump maxRetries back down because I never saw it take more than 3
fforbeck
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now offering free trials to users who come referred by other users, so we need to be able to display an alternate pricing table to those users.
This PR adds a check to the "email validated" screen that determines whether to offer users a free trial. It queries the referral service and renders the "free trial" pricing table if the user was referred.
This PR also removes some log lines that I accidentally introduced in a recent PR.